feat(config)!: use unqualified names for default_toolchain - #4947
Open
rami3l wants to merge 4 commits into
Open
Conversation
rami3l
changed the title
Cfg::get_default_resolvable()default_toolchain
rami3l
commented
Jul 9, 2026
rami3l
commented
Jul 9, 2026
rami3l
force-pushed
the
feat/unqualified-default-toolchain
branch
2 times, most recently
from
July 14, 2026 19:51
1d2c5c6 to
108ca96
Compare
This comment has been minimized.
This comment has been minimized.
rami3l
force-pushed
the
feat/unqualified-default-toolchain
branch
5 times, most recently
from
July 23, 2026 09:14
37bfef2 to
8975942
Compare
This comment has been minimized.
This comment has been minimized.
rami3l
force-pushed
the
feat/unqualified-default-toolchain
branch
from
July 23, 2026 10:51
8975942 to
bb5bf44
Compare
rami3l
commented
Jul 23, 2026
rami3l
commented
Jul 23, 2026
rami3l
force-pushed
the
feat/unqualified-default-toolchain
branch
from
July 25, 2026 08:14
bb5bf44 to
9f1d12c
Compare
rami3l
marked this pull request as ready for review
July 27, 2026 08:33
rami3l
force-pushed
the
feat/unqualified-default-toolchain
branch
from
July 27, 2026 08:33
9f1d12c to
5616ba4
Compare
This comment has been minimized.
This comment has been minimized.
djc
reviewed
Jul 28, 2026
| Ok(Some(toolchain.resolve(&self.default_host_tuple()?)?)) | ||
| } | ||
|
|
||
| /// Gets the configured default toolchain. |
Contributor
There was a problem hiding this comment.
Nit: documentation comment style.
Also, duplicating the documentation comment from get_default() seems pretty unhelpful. Ideally these documentation comments should tell a clear story about the difference and their interaction.
Member
Author
There was a problem hiding this comment.
@djc I think the new version should be better now?
| CustomToolchainName, | ||
| ResolvableToolchainName, | ||
| ResolvableToolchainName::Custom | ||
| ); |
Contributor
There was a problem hiding this comment.
I'm not a fan of these macros and have looked several times at cleaning them up. How about just writing them out (could inline macros with Rust-Analyzer I think)?
Member
Author
There was a problem hiding this comment.
@djc Done; also in that case I can make a separate PR to remove them entirely.
rami3l
force-pushed
the
feat/unqualified-default-toolchain
branch
from
August 3, 2026 07:59
5616ba4 to
34ad35f
Compare
This comment has been minimized.
This comment has been minimized.
rami3l
force-pushed
the
feat/unqualified-default-toolchain
branch
2 times, most recently
from
August 3, 2026 08:24
aa51f83 to
04c0cc9
Compare
rami3l
force-pushed
the
feat/unqualified-default-toolchain
branch
from
August 3, 2026 09:09
04c0cc9 to
52d7cb1
Compare
This comment has been minimized.
This comment has been minimized.
rami3l
force-pushed
the
feat/unqualified-default-toolchain
branch
from
August 3, 2026 12:51
52d7cb1 to
e737b5f
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4950 and #4991, closes #4945.
The breakage should be minimal anyway because the default host tuple almost never changes.