Skip to content

fix(toolchain)!: restrict named toolchain characters #4932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cachebag wants to merge 5 commits into
base: main
Choose a base branch
from
+240 −108
Open

fix(toolchain)!: restrict named toolchain characters #4932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
42e1495
refactor(toolchain): move name validation helper
cachebag Jul 1, 2026
7a40cf1
fix(toolchain)!: restrict named toolchain characters
cachebag Jul 1, 2026
cd50e82
doc: document custom toolchain name characters
cachebag Jun 30, 2026
f6b0be9
feat(toolchain/names): accept unicode identifiers in toolchain names
cachebag Aug 3, 2026
028f723
refactor(toolchain/names): inline `validate()` aliases into `FromStr`
cachebag Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ tracing = "0.1"
tracing-log = "0.2"
tracing-opentelemetry = { version = "0.33", optional = true }
tracing-subscriber = { version = "0.3.23", features = ["env-filter"] }
unicode-security = "0.1"
url = "2.4"
wait-timeout = "0.2"
xz2 = "0.1.3"
Expand Down
8 changes: 8 additions & 0 deletions doc/user-guide/src/concepts/toolchains.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ local builds of the Rust toolchain. To teach `rustup` about your build, run:
$ rustup toolchain link my-toolchain path/to/my/toolchain/sysroot
```

Custom toolchain names may contain any character that [UTS #39] allows in an
identifier, except for `:` and `'`. In practice that means letters and digits
in any script, along with `.`, `_`, and `-`; whitespace, most punctuation,
emoji, and invisible or direction-altering characters are rejected. The names
`.` and `..` are not accepted either.

[UTS #39]: https://www.unicode.org/reports/tr39/#Identifier_Status_and_Type

For example, on Ubuntu you might clone `rust-lang/rust` into `~/rust`, build
it, and then run:

Expand Down
Loading
Loading