Remove interior mutability in mir predecessors cache - #64736

Merged

bors merged 47 commits into

rust-lang:masterfrom

Nashenas88:mir_predecessors_cache_cleanup

Dec 2, 2019

Commits on Dec 2, 2019

Remove interior mutability in mir predecessors cache
Nashenas88
committed
c16ef6b
Inline cache impl into Body, rename predecessor fns, change output of predecessors_for to slice
Nashenas88
committed
b524059
Get rid of old comment
Nashenas88
committed
ce29f43
Stop invalidating predecessors cache when accessing unique basic block, invalidate cache when accessing unique terminator
Nashenas88
committed
f534d9f
Add pass to ensure predecessors cache is generated after optimization
Nashenas88
committed
2b31456
Fix Mir visitor macro to ensure it calls the proper method to invalidate the predecessors cache
Nashenas88
committed
e1afa51
Address linting errors caught by CI
Nashenas88
committed
570e418
Ensure predecessors are recomputed at critical points, fixes panics
Nashenas88
committed
8e8c97e
Move predecessors cache invalidation back to basic_blocks_mut, add a couple more ensure_predecessors to prevent panics
Nashenas88
committed
ad73468
Address excessive line length that was triggering warning during linting
Nashenas88
committed
94414ac
Address nits and remove unneeded pass
Nashenas88
committed
52cc85f
Add back cache invalidation to basic_blocks_and_local_decls_mut
Nashenas88
committed
22bc8a0
Move predecessors cache back to its own type
Nashenas88
committed
9b335ce
Move predecessor cache outside of Body, use wrapper types to manage Cache and Body (WIP, amend this commit)
Nashenas88
committed
c0592fa
Simplify Cache wrapper to single type, impl Deref on it, fix all compilation errors in librustc_codegen_ssa
Nashenas88
committed
649c73f
Remove Body from FunctionCx, pass it along during librustc_codegen_ssa
Nashenas88
committed
30b1d9e
Improved BodyCache body impl so it only returns a sharable ref, add new body_mut method, fix visit macros, simplify usage in codegen_ssa analyzer
Nashenas88
committed
3d68f5f
Add Body back as field of FunctionCx, but under a different lifetime
Nashenas88
committed
16952cc
Revert back to using FunctionCx's Body
Nashenas88
committed
66279d1
Convert &mut to & since the reference didn't need to be mutable
Nashenas88
committed
c8c266a
Account for new maybe_sideeffect helper that requires predecessors
Nashenas88
committed
2eed90a
Fix a large number of Body -> (ReadOnly)BodyCache type errors, add predecessor_locations fn to ReadOnlyBodyCache
Nashenas88
committed
ab98c59
Add read_only fn to BodyCache<&mut...> impl, fix more Body -> (ReadOnly)BodyCache type errors
Nashenas88
committed
26f1c01
Add predecessors fn to ReadOnlyBodyCache, fix more Body -> (ReadOnly)BodyCache type errors
Nashenas88
committed
0a19371
Fix typo caused by rebasing
Nashenas88
committed
3642a71
Fix remaining Body -> (ReadOnly)BodyCache type errors in librustc_mir outside of librustc_mir/transform
Nashenas88
committed
38c0887
Simplify BodyCache impl and fix all remaining type errors in librustc_mir (lifetime errors still exist)
Nashenas88
committed
fc6b58d
Fix remaining compilation issues
Nashenas88
committed
4de31b2
Fix typos caused during rebase
Nashenas88
committed
35590b5
Fix tidy errors
Nashenas88
committed
67b7a78
Fix typo
Nashenas88
committed
ab657e3
Fix compilation errors created during rebase
Nashenas88
committed
e54c610
Undo minor changes that weren't needed, fix one lifetime typo
Nashenas88
committed
c42bdb8
Remove BodyCache.body and rely on Deref as much as possible for ReadOnlyBodyCache
Nashenas88
committed
595d161
Remove HasLocalDecls impl from BodyCache's, properly reborrow to Body, rename all body_cache back to body
Nashenas88
committed
b2fe254
Fix typos caused during rebase
Nashenas88
committed
51b0665
Remove files created during conflict resolution
Nashenas88
committed
ed90818
Compute predecessors in mir_build query and use existing cache for generating ReadOnlyBodyCache, remove unneeded fns
Nashenas88
committed
05dc5e9
Fix type errors cause during rebasing
Nashenas88
committed
245abc4
Remove inline attributes that hadn't been profiled, unexport Cache since it no longer needs to be public
Nashenas88
committed
c6354e9
Remove unchecked inline attribute, remove unused functions, make chache mod private again
Nashenas88
committed
598797c
Fix type errors created during rebasing
Nashenas88
committed
64654ce
Fix rebasing errors, convert some BodyCache::body() calls to reborrows
Nashenas88
committed
9978574
Fix tidy issues
Nashenas88
committed
acb90eb
Use new HashStable proc macro
Nashenas88
committed
38bd3a2
Fix issues caused during rebasing
Nashenas88
committed
6123478
Fix issues caused during rebasing
Nashenas88
committed
3eaad56