Rollup of 20 pull requests - #161425
Open
JonathanBrouwer wants to merge 56 commits into
Open
Conversation
Adds the `desktop` method to the Windows `CommandExt` trait to enable setting the `lpDesktop` field of the STARTUPINFO passed to the Windows `CreateProcess` API call.
…'s `macro_rules!`
This would have been useful to have while debugging a problem in cg_clif.
When a macro call like `vec![]` appears in type position, the compiler's "use `=` if you meant to assign" suggestion was pointing into the macro definition in stdlib instead of the user's own code. The suggestion span was computed as `stmt.pat.span.between(hir_ty.span)`. After expansion `hir_ty.span` lies inside the macro body, so that span crossed syntax contexts and the renderer displayed the stdlib location. Compute the span via `find_ancestor_in_same_ctxt` instead, so the pattern and the type are compared in a common syntax context. When no common context exists -- e.g. the `let` comes from a macro body while the pattern is a call-site metavariable -- no suggestion is emitted at all.
There are only three impls of `Qualif`, and the extra explicitness is clearer.
Items with implicit `pub(self)` visibility in the crate root are effectively `pub(crate)`, which causes friction when trying to move them elsewhere.
This intermediate commit helps to preserve line history.
…=GuillaumeGomez Fix rustdoc remapping `documentation` scope documentation We have `--remap-path-scope` since rust-lang#155451, the documentation is outdated.
…nia-e Update expect messages in path docs to better follow guidelines Updates the `.expect()` messages in `library/std/src/path.rs` to better follow the guidance for `expect` messages. Related to rust-lang#159751.
rustbot
added
A-attributes
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 20, 2026
Rollup of 20 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple-1 try-job: aarch64-apple-2 try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: i686-msvc-2
Contributor
|
⌛ Trying commit 9bbba38 with merge 2016dbf… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/32409643233 |
Member
Author
|
Deliberately excluded #160524 #160995 |
Contributor
|
⌛ Testing commit 9bbba38 with merge ed96418... Workflow: https://github.com/rust-lang/rust/actions/runs/32409894661 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 20, 2026
…uwer Rollup of 20 pull requests Successful merges: - #152617 (std: implement `sleep_until` for Fuchsia) - #158934 (diagnostics: fix `let x: vec![]` suggestion pointing into stdlib) - #161277 (bootstrap: Move all non-module items out of the crate root) - #161295 (std: don't panic on long-elapsed deadlines for `sleep_until`) - #161368 (Double-word align `_Unwind_Exception`) - #161370 (Uplift rustfmt macro formatting fix) - #161378 (`FlowSensitiveAnalysis` cleanups) - #158032 (Offload expose device selection) - #158855 (Add `desktop` method to `CommandExt`) - #161199 (Add regression test for non lifetime binders) - #161302 (Add regression test for inconsistent import resolution from issue 147208) - #161329 (Add regression tests for a few fixed issues with E-needs-test) - #161330 (Add regression test for nested RPIT not an iterator ICE) - #161351 (Cleanup: Move impl of `#[rustc_dump_object_lifetime_defaults]`) - #161355 (Add file path to some archive build errors) - #161373 (Allow running EC2 jobs locally) - #161393 (Configure LLM policy URL for triagebot) - #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test) - #161410 (Fix rustdoc remapping `documentation` scope documentation) - #161415 (Update expect messages in path docs to better follow guidelines)
Member
the failure is from #160524 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
sleep_untilfor Fuchsia #152617 (std: implementsleep_untilfor Fuchsia)let x: vec![]suggestion pointing into stdlib #158934 (diagnostics: fixlet x: vec![]suggestion pointing into stdlib)sleep_until#161295 (std: don't panic on long-elapsed deadlines forsleep_until)_Unwind_Exception#161368 (Double-word align_Unwind_Exception)FlowSensitiveAnalysiscleanups #161378 (FlowSensitiveAnalysiscleanups)desktopmethod toCommandExt#158855 (Adddesktopmethod toCommandExt)#[rustc_dump_object_lifetime_defaults]#161351 (Cleanup: Move impl of#[rustc_dump_object_lifetime_defaults])tests/rustdoc-gui/notable-trait.gomltest #161409 (Add backtests/rustdoc-gui/notable-trait.gomltest)documentationscope documentation #161410 (Fix rustdoc remappingdocumentationscope documentation)r? @ghost
Create a similar rollup