Rollup of 16 pull requests - #161399
Closed
JonathanBrouwer wants to merge 49 commits into
Closed
Conversation
Adds the `desktop` method to the Windows `CommandExt` trait to enable setting the `lpDesktop` field of the STARTUPINFO passed to the Windows `CreateProcess` API call.
…'s `macro_rules!`
I wasn't able to find a test that verifies different behavior based on whether or not overflow checks are available, so add one here.
This would have been useful to have while debugging a problem in cg_clif.
When a macro call like `vec![]` appears in type position, the compiler's "use `=` if you meant to assign" suggestion was pointing into the macro definition in stdlib instead of the user's own code. The suggestion span was computed as `stmt.pat.span.between(hir_ty.span)`. After expansion `hir_ty.span` lies inside the macro body, so that span crossed syntax contexts and the renderer displayed the stdlib location. Compute the span via `find_ancestor_in_same_ctxt` instead, so the pattern and the type are compared in a common syntax context. When no common context exists -- e.g. the `let` comes from a macro body while the pattern is a call-site metavariable -- no suggestion is emitted at all.
There are only three impls of `Qualif`, and the extra explicitness is clearer.
Items with implicit `pub(self)` visibility in the crate root are effectively `pub(crate)`, which causes friction when trying to move them elsewhere.
This intermediate commit helps to preserve line history.
Change from the existing behavior of panicking unconditionally to panicking only if debug assertions are enabled, wrapping otherwise. This is more consistent with other operations, and gives slightly better codegen [1]. Suggested in the stabilization PR, RUST-161015. [1]: https://rust.godbolt.org/z/Yz81zhbno
Member
Author
Contributor
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 20, 2026
Rollup of 16 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple-1 try-job: aarch64-apple-2 try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: i686-msvc-2
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
PR #161204, which is a member of this rollup, was unapproved. This rollup was thus unapproved. |
Contributor
|
💔 Test for 7fa0181 failed: CI. Failed job:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
sleep_untilfor Fuchsia #152617 (std: implementsleep_untilfor Fuchsia)let x: vec![]suggestion pointing into stdlib #158934 (diagnostics: fixlet x: vec![]suggestion pointing into stdlib)sleep_until#161295 (std: don't panic on long-elapsed deadlines forsleep_until)_Unwind_Exception#161368 (Double-word align_Unwind_Exception)FlowSensitiveAnalysiscleanups #161378 (FlowSensitiveAnalysiscleanups)desktopmethod toCommandExt#158855 (Adddesktopmethod toCommandExt)#[rustc_dump_object_lifetime_defaults]#161351 (Cleanup: Move impl of#[rustc_dump_object_lifetime_defaults])r? @ghost
Create a similar rollup