Rollup of 12 pull requests - #161352
Closed
JonathanBrouwer wants to merge 30 commits into
Closed
Conversation
This patch implements Rust's equivalent of Clang's function pointer type discriminator computation used in pointer authentication. Compatibility with Clang is a primary goal. The discriminator produced for a given external "C" function type must match the value computed by Clang so that function pointers can be exchanged safely between Rust and C code while preserving pointer authentication semantics. The implementation mirrors Clang's behavior in `ASTContext::encodeTypeForFunctionPointerAuth`, ensuring that identical C-compatible function types produce identical discriminators. See: <https://clang.llvm.org/doxygen/ASTContext_8cpp.html#abb1375e068e807917527842d05cadea3>.
`MCOptions` is the name of the variable commonly used for instances of `MCTargetOptions`. Use the proper type name instead.
…parent]` is applied Co-authored-by: León Orell Valerian Liehr <me@fmease.dev>
…=davidtwco [PAC] Encoder and hash (1/8) This patch implements Rust's equivalent of Clang's function pointer type discriminator computation used for pointer authentication. Compatibility with Clang is a primary design goal. For a given extern "C" function type, the discriminator produced by Rust must match the value computed by Clang so that function pointers can be exchanged safely between Rust and C code while preserving pointer authentication semantics. The implementation mirrors Clang's behavior in ASTContext::encodeTypeForFunctionPointerAuth, ensuring that identical C-compatible function types produce identical discriminators. See: https://clang.llvm.org/doxygen/ASTContext_8cpp.html#abb1375e068e807917527842d05cadea3. --- This is part 1 of a sequence of 8 PRs that together implement support for function pointer type discrimination: 1. [Encoder and hash](rust-lang#159071) 2. [FnAbi, llvm.ptrauth.resign and Session API change](rust-lang#159074) 3. [FPTR_TYPE_DISCR in ABI Version](rust-lang#159075) 4. [Static allocs](rust-lang#159081) 5. [Transmutes](rust-lang#159082) 6. [Propagate discriminator logic through remaining get_fn_ptr calls sites](rust-lang#159084) 7. [Minicore updates to support fn ptr type discriminator tests](rust-lang#159086) 8. [Fn ptr type discrimination tests](rust-lang#159087) --- Useful links: * Previous PAC work: * `pauthtest` introduction: rust-lang#155722 * Library support follow up: rust-lang#156548 * Config follow up: rust-lang#156712 * [Project goal](https://rust-lang.github.io/rust-project-goals/2026/aarch64_pointer_authentication_pauthtest.html) and [tracking issue](rust-lang/goals#618) * Clang's implementation of [ASTContext::encodeTypeForFunctionPointerAuth](https://clang.llvm.org/doxygen/ASTContext_8cpp.html#abb1375e068e807917527842d05cadea3) * LLVM's [SpiHash](https://github.com/llvm/llvm-project/blob/main/third-party/siphash/include/siphash/SipHash.h)
Update the `rustc-perf` submodule To bring in rust-lang/rustc-perf#2537, so that we unblock rust-lang#160619. r? lcnr
…t, r=fmease rustdoc: Always document `#[repr(transparent)]` if `#[rustc_pub_transparent]` is applied Fixes rust-lang#150919
…r=davidtwco Add `remove hidden_glob_reexports item breaks downstream` test Adds the minimization of rust-lang#159901 to the test suite.
…=davidtwco remove unwrap from write_mir_fn_graphviz
Enhance EII UI tests The first commit enabled all EII tests on Windows MSVC. Two other PRs were merged almost simultaneously with my previous PR and they kept `ignore-windows` instead of `ignore-windows-gnu`. The second commit normalized EII dylib test coverage. Previously, there were only two dedicated negative tests and some auxiliary crates that had `no-prefer-dynamic` removed but whose `crate_type` was still `rlib` were accidentally compiled into `dylib`s and thus were tested unintentionally. This is now normalized: some tests will be tested under two revisions: `rlib` and `dylib` or `dylib-impl` (declaration in `rlib` & implementation in `dylib`). Note that `call_default_panics.run.stderr` is not updated; the file appears to be invalid, and I am unsure how to update this check.
…dtwco fix arm homogeneous aggregate ABI This started with abi-cafe finding a mismatch between rustc and clang/gcc, but turned into quite the rabbit hole of bits of ABI that were never implemented. The code is effectively ported from LLVM, and abi-cafe is happy now. The bug I hit was that aligned structs were passed incorrectly: https://godbolt.org/z/jErPoPrv5 The assertions for watchOS are best-effort, I can't actually run that. But, it's tier 3, it was already broken, so at worst it's just less broken now. The relevant code is in https://github.com/llvm/llvm-project/blob/551766823bb7b5a6af84e4ec1c1aff6dff431229/clang/lib/CodeGen/Targets/ARM.cpp, I'll link some specific parts. r? davidtwco
Download auto jobs in citool in parallel To make the post-merge workflow report the result sooner after a PR is merged, and also to make local experiments (also with the test dashboard) quicker. r? jieyouxu
Reserve capacity for 3% anon nodes This reserves capacity for 3% anon nodes instead of 100%. For the benchmark suite the mean is ~1.6% and max ~5.8%, so I picked a middle ground.
…JohnTitor Tighten the language used for documenting `TargetOptions::llvm_abiname` `MCOptions` is the name of the variable commonly used for instances of `MCTargetOptions`. Use the proper type name instead. It should make finding the [documentation](https://llvm.org/doxygen/classllvm_1_1MCTargetOptions.html) for the struct a bit easier.
Rename `ProjectionPredicate` and `TraitPredicate` Part of rust-lang#107250 This deviates from the plan I described in rust-lang#107250 (comment). The reason is that I kept getting into the awkward situation where I would go into a function dealing with multiple predicate/clause kinds, and need to rename only the variables referring with the particular kind I was renaming. So now, the plan is to first rename only the types (this PR), and afterwards go into functions and rename all the variables in them at once. That would also allow splitting the work better, e.g. tackling one crate/subtree at a time. r? @oli-obk
Remove a bunch of unnecessary explicit lifetimes Both rustdoc and hir ty lowering only process the HIR, they never store any of those nodes anywhere. The reason I did this is that I'm refactoring `hir::ItemKind::Use`, and for rustdoc's processing of it it is more convenient to create a bunch of values on the stack and reference them, but right now rustdoc was expecting `'tcx` lifetimes everywhere.
rustbot
added
A-CI
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 19, 2026
Rollup of 12 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple-1 try-job: aarch64-apple-2 try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: i686-msvc-2
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc-perfsubmodule #161344 (Update therustc-perfsubmodule)#[repr(transparent)]if#[rustc_pub_transparent]is applied #150931 (rustdoc: Always document#[repr(transparent)]if#[rustc_pub_transparent]is applied)remove hidden_glob_reexports item breaks downstreamtest #160582 (Addremove hidden_glob_reexports item breaks downstreamtest)TargetOptions::llvm_abiname#161283 (Tighten the language used for documentingTargetOptions::llvm_abiname)ProjectionPredicateandTraitPredicate#161291 (RenameProjectionPredicateandTraitPredicate)r? @ghost
Create a similar rollup