Cleanup: Move impl of #[rustc_dump_object_lifetime_defaults] - #161351
Open
fmease wants to merge 1 commit into
Open
Cleanup: Move impl of #[rustc_dump_object_lifetime_defaults]#161351fmease wants to merge 1 commit into
#[rustc_dump_object_lifetime_defaults]#161351fmease wants to merge 1 commit into
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
JonathanBrouwer
approved these changes
Aug 19, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module
rustc_passes::check_attrhosts validity checks for attributes (that can't be impl'ed inrustc_attr_parsing(yet)). However on main, the actual impl of#[rustc_dump_object_lifetime_defaults]lives there, too, which is wrong. Move it closer to the provider of the corresponding query (object_lifetime_defaults) which lives inrustc_hir_analysis. IIRC the eventual goal is to removecheck_attrentirely in favor ofrustc_attr_parsingif possible, meaning the impl probably has to move in the future anyway. Let's do it now.(No LLM was used in the creation of this PR)