Skip to content

Cleanup: Move impl of #[rustc_dump_object_lifetime_defaults] - #161351

Open
fmease wants to merge 1 commit into
rust-lang:mainfrom
fmease:mv-impl-dump-obj-lt-defs
Open

Cleanup: Move impl of #[rustc_dump_object_lifetime_defaults]#161351
fmease wants to merge 1 commit into
rust-lang:mainfrom
fmease:mv-impl-dump-obj-lt-defs

Conversation

@fmease

@fmease fmease commented Aug 19, 2026

Copy link
Copy Markdown
Member

Module rustc_passes::check_attr hosts validity checks for attributes (that can't be impl'ed in rustc_attr_parsing (yet)). However on main, the actual impl of #[rustc_dump_object_lifetime_defaults] lives there, too, which is wrong. Move it closer to the provider of the corresponding query (object_lifetime_defaults) which lives in rustc_hir_analysis. IIRC the eventual goal is to remove check_attr entirely in favor of rustc_attr_parsing if possible, meaning the impl probably has to move in the future anyway. Let's do it now.

(No LLM was used in the creation of this PR)

@fmease fmease added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Aug 19, 2026
@rustbot

rustbot commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 19, 2026
@rustbot

rustbot commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, types
  • compiler, types expanded to 75 candidates
  • Random selection from 16 candidates

Comment thread compiler/rustc_hir_analysis/src/collect/dump.rs

@JonathanBrouwer JonathanBrouwer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-bors Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8ac67c5 has been approved by JonathanBrouwer

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

Reason for tree closure: To keep an eye on

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants