Do not install new binutils on the system, only use it in gcc by GuillaumeGomez · Pull Request #161243 · rust-lang/rust

GuillaumeGomez · 2026-08-17T14:08:55Z

View all comments

As discussed in #161218.

cc @RalfJung @antoyo
r? @Kobzol

GuillaumeGomez · 2026-08-17T14:10:19Z

@bors try jobs=dist*linux

Do not install new binutils on the system, only use it in gcc try-job: dist*linux

antoyo · 2026-08-17T14:44:40Z

It seems you forgot to add --with-as and --with-ld.

GuillaumeGomez · 2026-08-17T15:32:50Z

It seems you forgot to add --with-as and --with-ld.

Indeed...

GuillaumeGomez · 2026-08-17T15:36:37Z

@bors try jobs=dist*linux

Do not install new binutils on the system, only use it in gcc try-job: dist*linux

Kobzol · 2026-08-17T15:42:30Z

    --prefix=/rustroot \
    --enable-languages=c,c++ \
    --disable-gnu-unique-object \
+    --with-as="$BINUTILS_PATH/as" \


Note that here you are providing as and ld to a GCC that will later build the libgccjit.so that we ship. I didn't realize it in the previous PR, but it's weird that this actually does something. I would expect that we have to provide the binutils to the build of our libgccjit.so, which is likely what the make install does (?).

View changes since the review

I would as well, but I'm unclear whether it's only used to be gcc or it's the paths gcc will use when running.

s/only used to be gcc/only used to build gcc/

Very annoying that we can't edit currently. ^^'

Isn't this the configure for the GCC 9.5?
The --with-as flags probably need to be in the dist.sh file to be in our libgccjit, no?

fbstj · 2026-08-17T16:53:29Z

+BINUTILS_PATH="$BINUTILS_ROOT_PATH/bin"
 curl https://ci-mirrors.rust-lang.org/rustc/gcc/binutils-$BINUTILS.tar.xz | xzcat | tar xf -
 mkdir binutils-build
+mkdir /binutils-install


Suggested change

mkdir /binutils-install

mkdir $BINUTILS_ROOT_PATH

am I missing something?

View changes since the review

Nope you're right.

rust-bors · 2026-08-17T19:10:01Z

💔 Test for 28ad8c1 failed: CI. Failed jobs:

try - dist-i686-linux (web logs, enhanced plaintext logs)
try - dist-x86_64-linux (web logs, enhanced plaintext logs)

RalfJung · 2026-08-17T19:33:08Z

Yes this seems to fix the Miri build :)

antoyo · 2026-08-17T19:35:50Z

Yes this seems to fix the Miri build :)

libgccjit is not built correctly here, but I guess this is good news.

GuillaumeGomez · 2026-08-17T19:56:19Z

Yes this seems to fix the Miri build :)

libgccjit is not built correctly here, but I guess this is good news.

What's wrong?

GuillaumeGomez · 2026-08-17T20:08:34Z

Now that github seems to be mostly back, let's restart the jobs.

@bors try jobs=dist*linux

Do not install new binutils on the system, only use it in gcc try-job: dist*linux

GuillaumeGomez · 2026-08-17T21:07:31Z

Seems like binutils and the compiler are kinda tied together? So if we use one version of binutils, we need to use it all the way. So what do we do? Should we try with binutils 2.46?

GuillaumeGomez · 2026-08-17T21:21:10Z

Let's try like this.

@bors try jobs=dist*linux

Do not install new binutils on the system, only use it in gcc try-job: dist*linux

RalfJung · 2026-08-20T21:07:40Z

I was just thinking it could cause strange effects and narrowing down the problem is easier if it's not in a rollup.
Definitely would have saved me some head-scratching for the first version of this PR that landed.^^

GuillaumeGomez · 2026-08-20T21:09:05Z

I'll never get back the years I lost wrecking my brain through both of these PRs. 😆 😭

@RalfJung

Do not install new binutils on the system, only use it in gcc As discussed in #161218. cc @RalfJung @antoyo r? @Kobzol

JonathanBrouwer · 2026-08-21T06:25:18Z

@bors yield
Yielding to the rollup

rust-bors · 2026-08-21T06:25:22Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/32454057116

The next pull request likely to be tested is #161434.

rust-log-analyzer · 2026-08-21T06:43:25Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

JonathanBrouwer · 2026-08-21T09:05:13Z

@bors p=4 scheduling

@RalfJung

Do not install new binutils on the system, only use it in gcc As discussed in #161218. cc @RalfJung @antoyo r? @Kobzol

rust-bors · 2026-08-21T12:20:43Z

💔 Test for bb9f25d failed: CI. Failed job:

auto - x86_64-msvc-1 (web logs, enhanced plaintext logs)

GuillaumeGomez · 2026-08-21T12:21:37Z

@bors retry

rust-log-analyzer · 2026-08-21T12:30:26Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

GuillaumeGomez · 2026-08-21T12:31:38Z

It was the same error twice in a row:

curl: (35) Recv failure: Connection was reset

@Kobzol Is something wrong?

JonathanBrouwer · 2026-08-21T12:36:43Z

@GuillaumeGomez That's still the rust-log-analyzer from the previous failure :D

GuillaumeGomez · 2026-08-21T12:45:47Z

Oh. Stress--

rust-bors · 2026-08-21T15:21:57Z

☀️ Test successful - CI
Approved by: Kobzol
Duration: 2h 57m 30s
Pushing b662191 to main...

github-actions · 2026-08-21T15:24:42Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 526c36b (parent) -> b662191 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b66219142c937562f2ff8e083be2a2b25b20199e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-gnu-llvm-22-2: 1h 39m -> 1h 1m (-38.5%)
x86_64-gnu-llvm-22-3: 1h 54m -> 1h 14m (-35.0%)
x86_64-gnu-gcc-core-tests: 16m 48s -> 10m 57s (-34.8%)
x86_64-gnu-stdlib-semver-check: 15m 11s -> 10m 18s (-32.2%)
arm-android: 1h 17m -> 1h 42m (+32.0%)
i686-gnu-nopt-1: 2h 13m -> 1h 32m (-31.1%)
x86_64-gnu-gcc: 58m 42s -> 1h 16m (+29.5%)
x86_64-gnu-next-trait-solver-polonius: 59m 30s -> 41m 59s (-29.4%)
dist-i586-gnu-i586-i686-musl: 27m 36s -> 19m 35s (-29.0%)
dist-x86_64-linux-alt: 1h 50m -> 2h 21m (+27.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-08-21T16:13:05Z

Finished benchmarking commit (b662191): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -7.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.0%	[-7.0%, -7.0%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 2.9%, secondary 1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	2.9%	[2.2%, 3.5%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.6%	[-1.6%, -1.6%]	1
All ❌✅ (primary)	2.9%	[2.9%, 2.9%]	1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 470.08s -> 470.067s (-0.00%)
Artifact size: 400.00 MiB -> 400.02 MiB (0.00%)

rust-bors Bot pushed a commit that referenced this pull request Aug 17, 2026

Auto merge of #161243 - GuillaumeGomez:binutils-install, r=<try>

8a9f6db

Do not install new binutils on the system, only use it in gcc try-job: dist*linux