bootstrap: Allow ./x fix --allow-dirty - #161220
Open
Zalathar wants to merge 2 commits into
Open
Conversation
Collaborator
|
This PR modifies If appropriate, please update |
rustbot
added
S-waiting-on-review
Collaborator
|
|
Kobzol
reviewed
Aug 17, 2026
This was already possible via `./x fix -- --allow-dirty`, but forwarding the argument from bootstrap is more user-friendly.
Member
|
Thanks! @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 18, 2026
bootstrap: Allow `./x fix --allow-dirty` - Extracted from rust-lang#160417, as `./x fix compiler` was fixed separately. --- This PR forwards `--allow-dirty` from bootstrap to cargo, making `./x fix` more convenient. This was already possible via `./x fix -- --allow-dirty`, but forwarding the argument from bootstrap is more user-friendly. r? Kobzol (or bootstrap)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 18, 2026
…uwer Rollup of 8 pull requests Successful merges: - #154210 (fix: fix the capture behavior of `if let` in closures) - #156176 (Initial implementation of `FnPtr` trait) - #160767 (Unify E0117 foreign-trait label for ADT/primitive types with existing Slice/Array/Tuple handling) - #160489 (Adding diagnostic item markers for multiple fs functions and structs) - #161220 (bootstrap: Allow `./x fix --allow-dirty`) - #161291 (Rename `ProjectionPredicate` and `TraitPredicate`) - #161296 (Enable overflow checks in `rustc_thread_pool`) - #161304 (Rename test so it matches the issue)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 18, 2026
bootstrap: Allow `./x fix --allow-dirty` - Extracted from rust-lang#160417, as `./x fix compiler` was fixed separately. --- This PR forwards `--allow-dirty` from bootstrap to cargo, making `./x fix` more convenient. This was already possible via `./x fix -- --allow-dirty`, but forwarding the argument from bootstrap is more user-friendly. r? Kobzol (or bootstrap)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 19, 2026
bootstrap: Allow `./x fix --allow-dirty` - Extracted from rust-lang#160417, as `./x fix compiler` was fixed separately. --- This PR forwards `--allow-dirty` from bootstrap to cargo, making `./x fix` more convenient. This was already possible via `./x fix -- --allow-dirty`, but forwarding the argument from bootstrap is more user-friendly. r? Kobzol (or bootstrap)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./x fix compilerand allow--allow-dirty#160417, as./x fix compilerwas fixed separately.This PR forwards
--allow-dirtyfrom bootstrap to cargo, making./x fixmore convenient.This was already possible via
./x fix -- --allow-dirty, but forwarding the argument from bootstrap is more user-friendly.r? Kobzol (or bootstrap)