delegation: simplify matches on FnKind, minor refactorings - #160853
Open
aerooneqq wants to merge 3 commits into
Open
delegation: simplify matches on FnKind, minor refactorings#160853aerooneqq wants to merge 3 commits into
FnKind, minor refactorings#160853aerooneqq wants to merge 3 commits into
Conversation
rustbot
added
S-waiting-on-review
aerooneqq
force-pushed
the
delegation-fn-kind-matches
branch
from
August 10, 2026 12:21
848f238 to
243131e
Compare
aerooneqq
force-pushed
the
delegation-fn-kind-matches
branch
from
August 12, 2026 07:09
e9a04e2 to
e680d29
Compare
Contributor
|
I'm generally skeptical about introduction of the extension trait. Removing unnecessary lifetime parameters (#160853 (comment)) will make things nicer if the current setup without the extension trait is kept. |
Contributor
|
The logic behind the fn kind matching refactoring is also not very clear to me. |
petrochenkov
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors matches on
FnKindmaking them smaller and more concise, next in all matches exceptfn_kindsfunction we no longer panic on delegation to inherent impls. And some minor renamings/refactorings. First step for #160505.Part of #118212.
r? @petrochenkov