Skip to content

Couple of misc improvements to the unwind infrastructure - #160440

Open
bjorn3 wants to merge 4 commits into
rust-lang:mainfrom
bjorn3:refactor_unwind4
Open

Couple of misc improvements to the unwind infrastructure#160440
bjorn3 wants to merge 4 commits into
rust-lang:mainfrom
bjorn3:refactor_unwind4

Conversation

@bjorn3

@bjorn3 bjorn3 commented Aug 3, 2026

Copy link
Copy Markdown
Member
  • Fix _Unwind_Exception size on Emscripten.
  • Move a link block.
  • Remove some manual dummy impls where there is already a dummy fallback.

Follow up to #159785

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 3, 2026
@rustbot

rustbot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from 6 candidates

@rust-bors

This comment has been minimized.

@Mark-Simulacrum

Copy link
Copy Markdown
Member

r=me with a rebase

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2026
bjorn3 added 4 commits August 12, 2026 17:28
The 20 word requirement was likely from the JS EH ABI which we no longer
support.
And change the dummy impl to use __rust_abort to match panic_abort.
@rustbot

rustbot commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@bjorn3

bjorn3 commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

@bors r=Mark-Simulacrum

@rust-bors

rust-bors Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 37831ee has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 13, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 13, 2026
…mulacrum

Couple of misc improvements to the unwind infrastructure

* Fix `_Unwind_Exception` size on Emscripten.
* Move a link block.
* Remove some manual dummy impls where there is already a dummy fallback.

Follow up to rust-lang#159785
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 13, 2026
…mulacrum

Couple of misc improvements to the unwind infrastructure

* Fix `_Unwind_Exception` size on Emscripten.
* Move a link block.
* Remove some manual dummy impls where there is already a dummy fallback.

Follow up to rust-lang#159785
rust-bors Bot pushed a commit that referenced this pull request Aug 13, 2026
Rollup of 14 pull requests

Successful merges:

 - #158918 (x86_64-win: Enable f128 on LLVM 23+)
 - #160288 (rustdoc: use anonymous constant for primitives/keywords/attribute docs)
 - #160440 (Couple of misc improvements to the unwind infrastructure)
 - #160441 (PowerPC inline ASM: Fix scalar floats being in the wrong vector lane on little endian)
 - #160896 (tidy: Update Python version requirements to 3.11)
 - #160972 (std: map ERROR_NEGATIVE_SEEK to ErrorKind::InvalidInput on Windows)
 - #161040 (Optimize CStr backing slice bounds checks)
 - #158885 (Add `core::num::Complex`)
 - #160928 (check `mut`-restriction when tuple constructor is used as a value)
 - #161002 (disallow `#[cold]` on `extern "custom"` functions)
 - #161016 (Fix invalid suggestion from try unlabled block)
 - #161020 (io: Use `NonNull` for all `Custom` API related to `Box`, update documentation for `Custom`)
 - #161044 (rustc-dev-guide subtree update)
 - #161046 (Enable unrolling feature of bors)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants