[rustdoc] Change table odd table rows background color to not make it the same as inline code - #160438
Open
GuillaumeGomez wants to merge 1 commit into
Open
[rustdoc] Change table odd table rows background color to not make it the same as inline code#160438GuillaumeGomez wants to merge 1 commit into
GuillaumeGomez wants to merge 1 commit into
Conversation
Collaborator
|
Some changes occurred in HTML/CSS/JS. |
rustbot
added
A-rustdoc-js
GuillaumeGomez
changed the title
Contributor
|
i feel like the odd/even colors should be swapped so they dont get doubled up if theres a header. and maybe too much of a nitpick but i feel like tables with a small number of rows (~2 or 3) dont need the alternating color. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159234.
Follow-up of #105442.
It now looks like this:
For the light theme, I had to make the inline code background darker so it would mix well with the alternative table rows background color.
r? @notriddle