Preserve placeholder ambiguity during normalization

[amirHdev]

View all comments

Fixes #159896

[rustbot]

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 74 candidates
• Random selection from 16 candidates

[chenyukang]

@rustbot reroll

[petrochenkov]

r? types

[lcnr]

I immediately get this change, can you provide some comment/PR description for what went wrong and why this is correct

r? BoxyUwU

[rustbot]

Failed to set assignee to BoxyUwU: error sending request

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

[amirHdev]

I immediately get this change, can you provide some comment/PR description for what went wrong and why this is correct

The problem was that the certainty of the nested goals was combined with the placeholder certainty and then dropped in the normalization path. It is fine to ignore ambiguity from nested goals there since those goals are returned to the caller. placeholder ambiguity is different because it is not reflected in the returned goals
this patch keeps the two values separate and only ignores the nested goal certainty

[lcnr]

r? lcnr makes sense

@bors r+ rollup

[rust-bors]

📌 Commit ba4e2f6 has been approved by lcnr

It is now in the queue for this repository.

[jhpratt]

@bors r- #160128 (comment)

[rust-bors]

This pull request was unapproved.

This PR was contained in a rollup (#160128), which was unapproved.

View changes since this unapproval

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[amirHdev]

@lcnr Rebased onto current main and fixed the ICE by restoring normalization of TypeOutlives caller bounds
@rustbot ready

[rustbot]

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

[rustbot]

Failed to set assignee to ready: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

[lcnr]

fixed the ICE by restoring normalization of TypeOutlives caller bounds

please don't. We should properly fix the underlying issues here instead, cc https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/rigid.20aliases.20in.20region.20handling/with/615617676

why does this PR result in new ICEs here? is that a case not covered in the zulip discussion?

[lcnr]

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[amirHdev]

why does this PR result in new ICEs here? is that a case not covered in the zulip discussion?

Yes this looks like a separate case
ocx.normalize produces a rigid opaque for the TypeOutlives clause but the following set_opaques_to_non_rigid turns it non-rigid again before region checking which triggers the ICE

Waiting for CI

[amirHdev]

@rustbot ready

[lcnr]

that's rust-lang/trait-system-refactor-initiative#293 please do not try to fix it in this PR as it is unrelated and the proper way to fix it is more involved. Would discuss this on zulip first

[rust-log-analyzer]

The job aarch64-gnu-llvm-21-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [ui] tests/ui/assumptions_on_binders/ambiguous-placeholder-certainty-issue-159896.rs stdout ----

error: Error: expected failure status (Some(1)) but received status Some(101).
status: exit status: 101
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/assumptions_on_binders/ambiguous-placeholder-certainty-issue-159896.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/assumptions_on_binders/ambiguous-placeholder-certainty-issue-159896" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2021" "-Znext-solver=globally" "-Zassumptions-on-binders"
stdout: none
--- stderr -------------------------------

thread 'rustc' (30608) panicked at compiler/rustc_trait_selection/src/regions.rs:35:17:
assertion failed: !infcx.next_trait_solver() || !type_outlives.has_non_rigid_aliases()
stack backtrace:
   0: __rustc::rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::panicking::panic