Use symlink_dir to create junctions on Windows instead of trying to use symbolic links in copy_link_internal

[Zoxc]

Symbolic links require extra privileges on Windows, so this falls back to creating junctions in symlink_file when operating on a directory.

[rustbot]

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: bootstrap
• bootstrap expanded to 6 candidates
• Random selection from Mark-Simulacrum, Zalathar, clubby789, jieyouxu

[ChrisDenton]

Junction points only work on directories, not files. A hard link or a file copy would be necessary if symlinks aren't available.

[Zoxc]

Well this seems to only be called to create junctions to directories (on Windows), otherwise I'd be seeing more privilege errors.

[ChrisDenton]

So it sounds like symlink_dir should be being called and it's a bug that symlink_file is.

[Mark-Simulacrum]

@rustbot author

I don't have much context on the details here (especially Windows) but generally speaking it seems plausible that this is a bug in the callsite?

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[Zoxc]

@rustbot ready

I have moved the logic to the callsite.

[ChrisDenton]

I should be able to look at this later today

r? ChrisDenton

[ChrisDenton]

lgtm

@bors r+ rollup

[rust-bors]

📌 Commit bbd34d2 has been approved by ChrisDenton

It is now in the queue for this repository.