replace source view / handler with redirect to crates.io source view - #3390
replace source view / handler with redirect to crates.io source view#3390syphar wants to merge 1 commit into
Conversation
51bfa85 to
de70f3e
Compare
eb421cd to
eb8c2ca
Compare
|
@GuillaumeGomez I'm not sure how to best fix the gui tests: |
|
crates.io source view doesn't work without JS unlike docs.rs. Not sure if important or not though... |
oh yeah, valid point. Do you have a tendency? Non-JS People won't even reach the source view through the menu, only way is probably through search results somehow. |
|
Someone mentioned on the crates.io zulip thread that it was an issue for them. |
I'm wondering:
|
I'd say no. But considering we had a meeting about rust websites coherency, I would have expected such discussions to happen before crates.io team decided to do it on their own with an inferior version in pretty much all regards, leaving the debate for us to decide if it's worth keeping these pages or just remove them and leave them to crates.io's.
The rustdoc output is incomplete, it doesn't list all files in the published crate, so the end goal is different. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cad329a to
1cdb098
Compare
This comment has been minimized.
This comment has been minimized.
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
IMO with the new crates.io source browser, we don't need our (super old) source browser any more.
Of course we'll keep the rustdoc source browsers. storage-features that were only there for the source browser can go too.
Happy to discuss, not sure if I forget use-cases that crates.io doesn't support?
I spent some time to build it in a way that old URLs to specific files are properly redirected to the corresponding crates.io source file.
Source archives stay for now, we use them to fetch readme's later. I might switch that to fetching them from crates.io too, let's see.
When this is deployed and works fine, we can stop storing the source file list in
releases.filesand drop the column. This will save us some storage and give us some performance.