fix: change int params in the EndpointupdateRequest struct - #313
Open
dhollinger wants to merge 2 commits into
Open
fix: change int params in the EndpointupdateRequest struct#313dhollinger wants to merge 2 commits into
dhollinger wants to merge 2 commits into
Conversation
updated the following parameters in the api.EndpointUpdateRequest struct from type `int` to an integer pointer. * WorkersMin * WorkersMax * IdleTimeout * ScalerValue This is to fix a bug in the enpoints where a value of `0` causes the generated JSON to omit these fields as "empty" as per the `omitempty` JSON tag. Changing them to integer points will allow a `nil` value to trigger the `omitempty` JSON tag, while a value of `0` will be treated as a valid value.
dhollinger
changed the title
Moved `wrkMax` to the top of the `TestUpdateEndpoint` function. Added a `wrkMin` with a value of `0` to the function. Added `WorkersMin` with the value of `wrkMin` to the encoded JSON in the test. Passed the `WorkersMin` paramter with a reference to the `wrkMin` address (`&wrkMin`) into the `client.UpdateEndpoint` call in the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the following parameters in the api.EndpointUpdateRequest struct from type
intto an integer pointer (*int).This is to fix a bug in the enpoints where a value of
0causes the generated JSON to omit these fields as "empty" as per theomitemptyJSON tag. Changing them to integer pointer (*int) will allow anilvalue to trigger theomitemptyJSON tag, while a value of0will be treated as a valid value.fixes #298
Test plan: