Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the plugin’s dependency packaging to avoid bundling commons-logging (which can conflict with Rundeck’s spring-jcl at runtime) while still making commons-logging available for tests.
Changes:
- Moved the Apache HttpClient version into
gradle.properties. - Excluded transitive
commons-loggingfrom the packagedhttpclientdependency so it won’t be bundled into the plugin JAR. - Added
commons-loggingas atestRuntimeOnlydependency to support test execution.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gradle.properties | Introduces centralized version properties for HttpClient and commons-logging. |
| build.gradle | Excludes transitive commons-logging from the packaged plugin libs and adds commons-logging for tests only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://pagerduty.atlassian.net/browse/RUN-4584
commons-logging dependency is excluded to avoid conflict when running on rundeck
commons-logging added for test scope only