Support MySQL TLS certificate config#297
Open
tonghia wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds CLI configuration for MySQL TLS certificates:
mysql-client-certandmysql-client-keymysql-ca-certparseTime=truetls=values when YAML TLS fields are usedtest-integration/mysql-tls-setup.shto generate disposable TLS certs and start a Docker MySQL TLS environmenttest-integration/mysql-tls.shfor simple real-env TLS verificationWhy
Issue #27 asks for a way to connect to MySQL servers that require client certificate authentication. The existing CLI only passed the datasource directly to
sql.Open, so it had no hook to callmysql.RegisterTLSConfigbefore connecting.Validation
go test ./sql-migratego test ./..../.idea/test-integration/mysql-client-cert-fixed.shgo build -o /tmp/sql-migrate-mtls-test/sql-migrate ./sql-migrate./test-integration/mysql-tls-setup.sh/tmp/sql-migrate-mtls-test/certssql-migrate-mtls-mysqlon port13306have_ssl=YESandrequire_secure_transport=ONcaonlywithREQUIRE SSLandmigratewithREQUIRE X509SQL_MIGRATE=/tmp/sql-migrate-mtls-test/sql-migrate ./test-integration/mysql-tls.shfor CA-only verificationMYSQL_USER=migrate MYSQL_PASSWORD=migratepass DATABASE_NAME=test_mtls MYSQL_CLIENT_CERT=/tmp/sql-migrate-mtls-test/certs/client-cert.pem MYSQL_CLIENT_KEY=/tmp/sql-migrate-mtls-test/certs/client-key.pem SQL_MIGRATE=/tmp/sql-migrate-mtls-test/sql-migrate ./test-integration/mysql-tls.shfor client-certificate verificationREQUIRE SSLMySQL user and config containing onlymysql-ca-cert,mysql-server-name, andmysql-tls-config;sql-migrate statusconnected successfully