Add informational commands: absolute-time, when-end, info recording#4083
Open
timo wants to merge 5 commits into
Open
Add informational commands: absolute-time, when-end, info recording#4083timo wants to merge 5 commits into
timo wants to merge 5 commits into
Conversation
absolute-time gives the absolute monotonic clock time from the current event. This is useful when you want to align events with a perf recording that also uses the monotonic clock (you still have to scale by 1000000000 of course.) when-end gives the event number of the last event in the whole recording. This is useful when running a replay with non-stopping breakpoints and displaying the "progress" of the replay to the user. info recording prints out the path of the recording folder. This is useful for running additional `rr replay` sessions from an existing one, or for calling `rr dump` to get data that is not otherwise surfaced by any gdb commands.
126ef3c to
ddceba5
Compare
* Assert that the result doesn't change at different points in the replay * Assert that the result is the same as what you get after running to the end of the replay * Assert that none of the "when" results are higher than the when-end one.
117aa7d to
2c1ae70
Compare
Author
|
Tests written, I think the code is ready for a review now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
absolute-time gives the absolute monotonic clock time from the current event.
This is useful when you want to align events with a perf recording that also uses the monotonic clock (you still have to scale by 1000000000 of course.)
when-end gives the event number of the last event in the whole recording.
This is useful when running a replay with non-stopping breakpoints and displaying the "progress" of the replay to the user.
info recording prints out the path of the recording folder.
This is useful for running additional
rr replaysessions from an existing one, or for callingrr dumpto get data that is not otherwise surfaced by any gdb commands.The next thing I am going to do is write tests for these commands, but I'd like to already PR the changes to get feedback on whether the implementation and the names of the commands are OK.
Thanks!