Skip to content

Add grace period support to pod deletion action #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arikalon1 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

Add grace period support to pod deletion action #2125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion playbooks/robusta_playbooks/pod_actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,12 @@ class DeleteAlertPodParams(ActionParams):
"""
:var rate_limit: Optional rate limit (seconds). If set, the action will only run once per period for the same alert label value.
:var rate_limit_field: Alert label name whose value is used to build the rate limit key.
:var grace_period_seconds: Optional grace period (seconds) for the pod deletion. Zero means delete immediately. If not set, the pod's default grace period is used.
"""

rate_limit: Optional[int] = None
rate_limit_field: Optional[str] = None
grace_period_seconds: Optional[int] = None


@action
Expand Down Expand Up @@ -62,4 +64,4 @@ def delete_alert_pod(event: PrometheusKubernetesAlert, params: DeleteAlertPodPar
logging.info(f"delete_alert_pod rate limited for {key}; skipping deletion")
return

pod.delete()
pod.delete(grace_period_seconds=params.grace_period_seconds)
Loading