preserve large numeric job args#594
Draft
bgentry wants to merge 1 commit into
Draft
Conversation
Job args can contain database identifiers that exceed JavaScript's safe integer range. The API previously emitted args as nested JSON, so `response.json()` converted large numeric literals to rounded `number` values before the UI could render or copy them. Return job args as JSON text from both the standard and Pro job serializers, and map that field to `argsRaw` in the frontend model. Job list, job detail, and workflow detail now render args through a lossless JSON text formatter that sorts object keys while preserving number tokens as text. Coverage exercises the wire contract for standard and Pro job responses, the frontend fetch path for job and workflow responses, and the list/detail rendering paths for the reported large integer scenario.
bgentry
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Job args can contain database identifiers larger than JavaScript's safe integer range. The previous API returned args as nested JSON, so browser JSON parsing could round those literals before the list and detail pages rendered them.
This changes job-shaped API responses to return args as JSON text and maps that value to
argsRawin the frontend. The list and detail views now render that text through a lossless sorter, preserving large number tokens while keeping object keys sorted for display and copied output.Closes #593.