refactor(ddd)!: harden DDD primitives - #77
Merged
Conversation
🦋 Changeset detectedLatest commit: c3f98e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Added a new method to the AggregateRoot class to retrieve and clear domain events. This enhances the event handling capabilities of aggregates. Additionally, refactored the Order class to reposition the record method for clarity and removed unnecessary comments in the User class constructor. Updated the Entity class to improve the structure of properties and maintain immutability.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Harden the
@rineex/dddtactical DDD primitives and migrate affected authentication consumers to the new contract.Scope
Breaking changes
Entitysubclasses implementvalidateProps(...)and explicitly validate after construction.AggregateRootevent recording is protected; callers use aggregate behavior rather thanaddEvent(...).node:cryptois removed from the DDD event base class.Changeset
@rineex/ddd: major releaseValidation
@rineex/ddd: typecheck, 183 tests, lint, and build pass.Known pre-existing issues
Authentication typecheck still reports unrelated missing OAuth repository symbols, a missing passwordless repository module, and existing MFA registry/test-fixture errors.