fix(relay): scope-gate PDP context headers#338
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 209c2ee377
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
209c2ee to
8381cb0
Compare
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
8381cb0 to
3b32b28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registry:trust:<field>:<value>scopes before Relay accepts subject, relationship, delegation actor, credential-format, or source-observation headers as PDP contextCloses #208.
Security review
The platform PDP review confirmed these fields are not universally match-only. Required-context, relationship, credential-format, and freshness policy shapes can use their presence or value on a Permit path. Relay therefore omits every listed header from PDP context unless the authenticated principal carries the exact value-bearing trust scope.
Audit provenance enrichment stays at the Relay boundary after exact-scope validation because other platform PDP consumers do not assign the same trust semantics to these context fields. Decision audits record field names only; tests cover Permit and Deny and prove that raw subject, relationship, delegation, and credential-format values are absent.
No route, static scope, source-read ordering, redaction, error shape, or OpenAPI surface changes.
Data-Purposeremains caller-stated purpose context and is explicitly not documented as trust evidence. The mechanical security-invariant checklist passes. A final independent staff review approved the corrected design with no actionable findings.Validation
cargo test --locked -p registry-platform-pdpcargo test --locked -p registry-notary-server matching_pdp_decision_ --libcargo test --locked -p registry-relaycargo test --locked -p registry-relay --all-featurescargo check --locked --workspace --all-targets-D warningscargo deny checkjust openapi-contractand Notaryjust openapi-checknpm testand fullnpm run check, including current and archived builds plus link validationThe Relay-local
deny.tomlstep injust cistill rejects the workspace-pinned Crosswalk git source and lacks the root advisory ignores. The authoritative rootcargo deny checkpasses; this is the documented pre-existing per-product deny mismatch, not a change from this PR.