fix(notary): preserve federation denial audit context#337
Merged
Conversation
fdea569 to
cb2cc47
Compare
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
cb2cc47 to
e4002dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #327.
Security review notes
This is security-sensitive audit and replay-path work.
Verification
Passed:
cargo fmt --checkgit diff --checkcargo check --locked --workspace --all-targetscargo clippy --locked --workspace --all-targets -- -D warningscargo clippy --locked -p registry-notary-server --all-targets -- -D warningsafter the final review fixcargo test --locked -p registry-notary-servercargo test --locked -p registry-notary-server --features registry-notary-cel federation_ -- --test-threads=1CARGO_PROFILE_TEST_DEBUG=0 cargo test --locked --workspacecargo deny checkpython3 release/scripts/check-gates-inventory.pypython3 -m unittest release/scripts/test_check_gates_inventory.pyproducts/notary: just openapi-check && just exposure-checkcrates/registry-relay: just openapi-contract && just exposure-checkThe full
registry-notary-serverCEL-feature suite reached 363 passing executions before the untouchedcross_source_cel_claim_reads_dependencies_with_distinct_tokenstest failed to build its router because its fixture omits the now-required deployment profile (deployment.profile_undeclared). The focused federation CEL suite passes, the default Notary suite passes, and root CI does not run the Notary all-feature suite. This PR does not mix that unrelated fixture repair into #327.Docs-site checks were not run because
docs/sitedid not change. The new amd64-only registryctl tutorial job is left to CI because the local host is arm64.