Support chaining FindQuery filters - #844
Draft
lh0156 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #780 by allowing
FindQueryinstances to accept additional filter expressions through.find().What changed
FindQuery.find(*expressions)and returns a new query, leaving the original unchanged.Model.find(expr1, expr2).Testing
pytest -q tests/test_find_query.py tests_sync/test_find_query.py: 52 passed.pytest -q tests --ignore tests/test_benchmarks.py: 261 passed.pytest -q tests_sync --ignore tests_sync/test_benchmarks.py: 261 passed.ruff checkandruff format --checkon changed source/tests.python -m compileall -q aredis_om tests.bandit -q -r aredis_om/model/model.py -s B608.Redis Stack was run locally through Docker Compose for the integration tests; benchmark tests were excluded from the full run.