feat(tkn): add Tekton task for IBM Cloud Gaudi provisioning - #879
feat(tkn): add Tekton task for IBM Cloud Gaudi provisioning#879deekay2310 wants to merge 2 commits into
Conversation
First IBM Cloud Tekton task in mapt. Exposes the `mapt ibmcloud ibm-gaudi create/destroy` CLI (merged in PR redhat-developer#834) for pipeline consumption via `infra-ibmcloud-ibm-gaudi` task. Resolves: redhat-developer#876 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 16 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds a Tekton task for IBM Cloud Gaudi instance creation and destruction. The task loads credentials, runs ChangesIBM Cloud Gaudi provisioning
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant TektonTask
participant Provisioner
participant mapt
participant IBMCloud
participant OpenShift
TektonTask->>Provisioner: Run create or destroy operation
Provisioner->>mapt: Execute ibmcloud ibm-gaudi command
mapt->>IBMCloud: Provision or destroy instance
IBMCloud-->>mapt: Return host information
mapt-->>Provisioner: Write shared host information
Provisioner-->>OpenShift: Create host-access Secret
OpenShift-->>TektonTask: Publish Secret name as result
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| if [[ "$(params.otel-app-code)" != "" ]]; then | ||
| cmd+="--otel-app-code '$(params.otel-app-code)' " | ||
| fi | ||
| if [[ "$(params.otel-auth-token)" != "" ]]; then |
There was a problem hiding this comment.
This is the first time I think in the otel params... would it make sense to add them as a secret? WDYT?
There was a problem hiding this comment.
Agreed, otel-auth-token could be handled as a secret. What about other otel params such as otel-endpoint, otel-index, etc?
There was a problem hiding this comment.
Moved otel-auth-token to the ibmcloud credential secret — it's now read from the secret mount with a graceful fallback if absent. The other otel params (endpoint, index, app-code, extra-attrs) are non-sensitive config, so kept them as plain params. Also added zone as a plain param for IC_ZONE per CodeRabbit's suggestion.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tkn/template/infra-ibmcloud-ibm-gaudi.yaml`:
- Around line 36-41: Complete the IBM Cloud credential contract by adding
IBMCLOUD_ACCOUNT and IC_ZONE inputs in
tkn/template/infra-ibmcloud-ibm-gaudi.yaml lines 36-41, then load and export
both values in lines 168-173. Regenerate the corresponding credential schema in
tkn/infra-ibmcloud-ibm-gaudi.yaml lines 36-41 and credential-loading code in
lines 168-173 so both files remain synchronized.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6d97f871-d919-4f6c-a2c9-49c2c4007bd1
📒 Files selected for processing (3)
Makefiletkn/infra-ibmcloud-ibm-gaudi.yamltkn/template/infra-ibmcloud-ibm-gaudi.yaml
Address PR review feedback: - Move otel-auth-token from plain Tekton param to the ibmcloud credential secret (read from mount with fallback) - Add zone param for IC_ZONE when subnet-id is not provided - Print IC_ZONE in debug output
2 participants
Summary
infra-ibmcloud-ibm-gauditask (template + generated)mapt ibmcloud ibm-gaudi create/destroyCLI from PR AIPCC:15489: Add support for Gaudi accelerator in mapt's IBM Cloud module #834 for pipeline consumptiontkn_updateandtkn-pushtargetsResolves #876
Test plan
make tkn-updategenerates task with correct image/version substitution🤖 Generated with Claude Code