Feat: RunOnInfra to use openshift.io/node-selector annotation on namespace#1194
Feat: RunOnInfra to use openshift.io/node-selector annotation on namespace#1194anandrkskd wants to merge 2 commits into
Conversation
…pod infra NodeSelector with openshift.io/node-selector annotation on default namespace. OpenShift admission controller applies selector to all pods in namespace automatically. Tolerations and custom NodeSelector remain at pod level. assited-by: claude-code Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
This PR changes
RunOnInfrafield implementation it addsopenshift.io/node-selector="node-role.kubernetes.io/infra=“annotation on namespace and let openshift make sure the pods are scheduled on infra nodes. Previous implementation used to add node-role label to resources directly.Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes GITOPS-9926
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
make install runspec.runOnInfra: trueopenshift.io/node-selector="node-role.kubernetes.io/infra=“