Skip to content

[AutoImport] Avoid used import into param that skipped from removal rule#8078

Open
samsonasik wants to merge 6 commits into
mainfrom
avoid-removed
Open

[AutoImport] Avoid used import into param that skipped from removal rule#8078
samsonasik wants to merge 6 commits into
mainfrom
avoid-removed

Conversation

@samsonasik

@samsonasik samsonasik commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This happen when:

  • There is enabled RemoveUnusedConstructorParamRector
  • Skipped on the target fixture
  • Apply auto import with removal unused use (marked as removable, which should not)

Ref #8043 (comment)

@samsonasik samsonasik mentioned this pull request Jun 22, 2026
Merged
@samsonasik

samsonasik commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

@TomasVotruba it seems due to refactor() calls for unused skip config feature on 2.5.x

@samsonasik

samsonasik commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

Fixed /cc @ruudk @TomasVotruba

@samsonasik samsonasik requested a review from TomasVotruba June 22, 2026 14:54
@samsonasik

samsonasik commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

@TomasVotruba ready 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

1 more reviewer

@peterfox peterfox peterfox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik @peterfox