[perf] Avoid call refactor() twice on AbstractRector#8077
Closed
samsonasik wants to merge 1 commit into
Closed
Conversation
Member
Author
|
@TomasVotruba ready 👍 |
| // whether it would actually have changed anything. Only a skip that prevents a real change | ||
| // counts as used; the original node is left untouched, so the file stays skipped either way. | ||
| $skipMatch = $this->skipper->matchSkip($this, $filePath); | ||
| $nodeToRefactor = $skipMatch instanceof SkipMatch ? $this->cloneNode($node) : $node; |
Member
There was a problem hiding this comment.
This is quite hard to read.
Member
|
It's called only once, see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #8076 (review)