[skip] track used skips as class => [paths] map#8074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks used skips as a
class => [path, path2]map instead of flatclass|pathjoin strings, matching the shape skips are already configured with in->withSkip().Before
ProcessResult::getUsedSkips()returnedstring[]where rule-scoped skips were encoded as"class|path", forcing the resolver to rebuild that join string to test membership:After
getUsedSkips()returnsarray<string, string[]>— rule class to its matched paths — so the lookup is a direct nested check:Changes
UsedSkipCollector::markUsed(string $skip, ?string $path = null)stores a nested map;provide()returnsclass => [paths].SkipSkippermarks the matched path under its rule instead of joining with|.ProcessResultconstructor/addUsedSkips()validate and merge the nested shape per key.ParallelFileProcessormerges worker maps nested.array_key_exists.Tests updated accordingly.
composer complete-checkgreen.