[skip] display skips only on uncached run#8071
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Display unused skips only on an uncached run
Follow-up to unused-skip reporting. On a cached run only the changed files are re-processed, so skips on cached files never get a chance to match and would all look falsely unused. This disables unused-skip reporting whenever the run is incomplete.
Changes
Option::IS_CACHED_RUN— new internal flag, set inUnchangedFilesFilterwhen the unchanged-files cache drops at least one file from the run (count($changedFileInfos) < count($filePaths)).UnusedSkipResolver— returns[]whenIS_CACHED_RUNis set, so no false positives reach console or JSON output.MissConfigurationReporter— adds a blank line between listed items, keeping grouped rule skips visually separated.testResolvesNothingWhenRunIsCachedcovers the cached-run guard.Clear the cache (
--clear-cache) to get full unused-skip reporting again.