Support configurable bind addresses#48
Merged
Merged
Conversation
The monitor header always displayed the loopback endpoint even when the proxy listened on another interface. This made the TUI misleading and could obscure network exposure from an explicit non-loopback configuration. Pass the listener's effective socket address into the monitor, render its URL in the header, and cover IPv6 formatting in the TUI test. Update the serve command reference to describe the configurable bind address.
28dea96 to
ece0c1b
Compare
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bindAddressconfig andCCP_BIND_ADDRESSenvironment override127.0.0.1as the safe default and report invalid IPs clearlyThis makes the proxy usable in containerized deployments without changing the
default host behavior. The proxy still binds only to loopback unless explicitly
configured otherwise.
Testing
cargo test --locked