fix(#1351): hide ScrollArea scrollbar when overlay is open#1997
Conversation
Track overlay open state on the document and suppress ScrollArea scrollbars when floating layers lock page scroll.
|
Track floating overlays via data-rad-ui-overlay-open and body scroll lock so custom ScrollArea scrollbars stay hidden alongside native scrollbars when dialogs, menus, or other floating layers open.
|
Warning Review limit reached
More reviews will be available in 15 minutes and 32 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (15)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
CoverageThis report compares the PR with the base branch. "Δ" shows how the PR affects each metric.
Coverage improved or stayed the same. Great job! Run |
Code reviewLGTM. Matches project patterns for portal Theme refs, Floating UI prop merge, controlled-switch/lazy-mount/RTL tests, or focused bug fixes. No changes requested. |
Summary
data-rad-ui-overlay-open) with refcounting when Dialog, Popover, Menu, and Combobox primitives open.bodyscroll is locked (e.g. modal scroll lock).Fixes #1351
Test plan
npm test -- --testPathPatterns=ScrollArea.test