Add external coupling for input and output conversion of liquid fuels#3452
Open
robindesmit-quintel wants to merge 4 commits into
Open
Add external coupling for input and output conversion of liquid fuels#3452robindesmit-quintel wants to merge 4 commits into
robindesmit-quintel wants to merge 4 commits into
Conversation
3 tasks
mabijkerk
changed the title
mabijkerk
force-pushed
the
add-liquid-fuels
branch
from
3706b07 to
23070a2
Compare
Member
|
@robindesmit-quintel if there is only one input carrier, then a coupling input is not necessary (and does not work). For example Can you remove the unnecessary ones? |
Member
|
The input names are getting very long, what about dropping all the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We want to introduce an external model to adjust the conversion ratios of the liquid fuels processes. The ETM should include an option to couple this external model to the original ETM.
Implemented changes
Add the external coupling inputs in organised folders.
Related
Closes issue MD-1296 (https://linear.app/quintel-i/issue/MD-1296/add-external-coupling-inputs-to-etsource)
Goes with pull requests #4741 (quintel/etmodel#4741)
Checklist