fix: implement missing utilities and fix edge-case bugs#248
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator.divide: throw on division by zero instead of returning Infinity - date-utils.formatRelative: round day count so 36h reads as 2 days ago - string-utils: implement wordCount multi-space handling and truncate word-boundary logic - task-manager: implement remove, update, and sortBy methods - validator: allow long TLDs in isEmail and ports in isUrl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests across the utility library. The full suite now passes: 60 pass / 0 fail. No test files were modified and no dependencies were added.
Changes
src/calculator.ts—dividenow throwsError("Division by zero")on a zero divisor instead of returningInfinity.src/date-utils.ts—formatRelativenow rounds the day count (Math.round) so an exact 36-hour delta reads as "2 days ago", matching the test's expectation.src/string-utils.ts— implementedwordCounthandling of multiple consecutive spaces; implementedtruncateword-boundary logic (returns unchanged within limit, truncates at word boundary, ellipsis counts towardmaxLength, handles strings shorter than the ellipsis).src/task-manager.ts— implementedremove(returnsfalsefor unknown ids),update(title/priority,falsefor unknown ids), andsortBy(priority high>medium>low, andcreatedAtoldest-first).src/validator.ts—isEmailnow accepts long TLDs;isUrlnow accepts URLs with a port (e.g.http://localhost:3000). Removed a staleBUG:JSDoc note that no longer applied.Verification
bun test→ 60 pass, 0 fail, 70 expect() calls.Assumptions
Math.round(notMath.floor) is the correct rounding forformatRelative.updatemutates the task in place (it holds the same reference stored in the Map), which is consistent with the existingadd/getsemantics.🤖 Generated with QuantCode Agent