fix: repair failing tests and implement missing utility functions#245
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests and implement missing utility functions#245stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
- calculator: divide now throws on division by zero - string-utils: wordCount collapses consecutive whitespace; truncate implemented with word-boundary + ellipsis - task-manager: implement remove, update, and sortBy methods - date-utils: fix off-by-one in formatRelative (Math.round instead of Math.floor) - validator: allow long TLDs in isEmail and ports in isUrl - remove stale BUG comments after fixes All 60 tests pass (was 44 pass / 16 fail).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across the utility library and implements the missing functionality. Test suite went from 44 pass / 16 fail → 60 pass / 0 fail. Only source files in
src/were changed — no test files modified, no dependencies added.Changes
src/calculator.ts—dividenow throws on division by zero instead of returningInfinity.src/string-utils.ts—wordCountcollapses consecutive whitespace;truncateimplemented (word-boundary cut,...ellipsis counting towardmaxLength, returns unchanged when short enough).src/task-manager.ts— implementedremove(id),update(id, changes), andsortBy(field)(priority ordered high > medium > low).src/date-utils.ts— fixed off-by-one informatRelative(usesMath.round, so 36h → "2 days ago").src/validator.ts—isEmailaccepts long TLDs (e.g..museum);isUrlaccepts URLs with ports (e.g.http://localhost:3000).BUG:comments left over from the fixes.Verification
bun test→ 60 pass / 0 fail / 70 expect() calls.Assumptions