fix: repair failing tests across utility library#244
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: throw on division by zero instead of returning Infinity - string-utils: fix wordCount for consecutive whitespace; implement truncate at word boundary - task-manager: implement remove, update, and sortBy methods - date-utils: fix off-by-one in formatRelative (round instead of floor) - validator: allow long TLDs in isEmail and ports in isUrl - remove stale BUG comments now that behaviour is fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously failing tests across the TypeScript utility library. All 60 tests now pass (0 fail), with none of the 44 previously-passing tests broken. No test files were modified and no dependencies were added.
Changes
src/calculator.ts—dividenow throws on division by zero instead of returningInfinity.src/string-utils.ts—wordCountnow handles consecutive whitespace correctly (splits on/\s+/after trim);truncateimplemented to cut at a word boundary with the ellipsis counting towardmaxLength.src/task-manager.ts— implemented the previously-stubbedremove,update, andsortBymethods.src/date-utils.ts— fixed off-by-one informatRelative(rounds instead of floors, so 36h → "2 days ago").src/validator.ts—isEmailnow accepts long TLDs (e.g..museum);isUrlnow accepts an optional port (e.g.http://localhost:3000).BUG:JSDoc comments that described the now-fixed behaviour.Assumptions
dividethrows a genericError("Division by zero")— no specific error type was mandated by the tests.Testing
bun test→ 60 pass, 0 fail (70 expect() calls, 5 files).Reviewed by the review subagent; no blocking issues found.