Skip to content

Qualcomm AI Engine Direct - Optimize performance of pcq embedding#20686

Open
shewu-quic wants to merge 1 commit into
pytorch:mainfrom
CodeLinaro:dev1/hutton/optimize_pcq_embedding
Open

Qualcomm AI Engine Direct - Optimize performance of pcq embedding#20686
shewu-quic wants to merge 1 commit into
pytorch:mainfrom
CodeLinaro:dev1/hutton/optimize_pcq_embedding

Conversation

@shewu-quic

Copy link
Copy Markdown
Collaborator

Summary:

  • Change pcq embedding pattern for backend optimization
    • Note that it is supported after QNN 2.48

Test plan

python3 backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperator.test_qnn_backend_embedding_per_channel --build_folder  build-android  --host {HOST} --device {DEVICE}   --soc_model SM8850  -a {ARTIFACTS} 

@pytorch-bot

pytorch-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20686

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 11bd40c with merge base 71a80d7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary:
- Change pcq embedding pattern for backend optimization
@shewu-quic shewu-quic force-pushed the dev1/hutton/optimize_pcq_embedding branch from 231b11e to 11bd40c Compare July 2, 2026 04:05
@shewu-quic

Copy link
Copy Markdown
Collaborator Author

Hi @psiddh,
This PR is to optimize performance for PCQ embedding on HTP.
Could you please have a look?
Thanks,
Hutton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant