Validate out-of-order tables incrementally while parsing#509
Open
gaoflow wants to merge 1 commit into
Open
Conversation
191e8d2 to
eb798da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #479.
Parsing n dotted keys (or table headers) that share a prefix is super-cubic: every append to an out-of-order key triggers
OutOfOrderTableProxy.validate, which re-merges — and deep-copies — every earlier fragment into a fresh temp container, and the membership probe inappend()rebuilds the full proxy each time as well. Profiling the issue's payload shows ~13Mdeepcopycalls for 60 keys.Three changes, all confined to parse time (
_parsedcontainers):_validate_out_of_order_tablekeeps a per-key cache of (fragments validated so far, temp container) and resumes from there, so each fragment is merged and deep-copied exactly once. Fragments are only appended during parsing; any other mutation (remove,_remove_at,_replace_at) clears the cache, and a validation failure drops the entry so a caught-and-retried error can't resume from a partially merged container.__contains__skips rebuilding the proxy when the cache shows exactly the current fragments already validated clean.isinstance(idx, tuple), so stale entries are harmless).Benchmark (the issue's repro):
Error behavior is unchanged: collisions across fragments still raise at parse time (added tests), and the existing suite passes unmodified.