Avoid mutating ErrorTree on missing child lookup#1495
Closed
mconsalvo95-tech wants to merge 1 commit into
Closed
Conversation
Documentation build overview
|
Author
|
Closing this after noticing that #1457 already addresses the same ErrorTree behavior. Sorry for the duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1328.
This replaces
ErrorTree's internaldefaultdictchild storage with an explicit dictionary so reading a valid child with no errors does not persist an empty subtree. Existing error paths are still populated during construction, and invalid indices still propagate the underlying instance lookup error.Tests:
uv run --group test python -m unittest jsonschema.tests.test_exceptionsPYTHONUTF8=1 JSON_SCHEMA_TEST_SUITE=json uv run --group test virtue jsonschemauv run --with ruff ruff check jsonschema\exceptions.py jsonschema\tests\test_exceptions.py