Skip to content

fix(bounties): only allow claiming a funded bounty (prevents payout for unfunded bounties) #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AliaksandrNazaruk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(bounties): only allow claiming a funded bounty (prevents payout for unfunded bounties) #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions apps/web/app/api/bounties/[id]/claim/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,12 @@ export async function POST(req: NextRequest, { params }: { params: Promise<{ id:
const bounty = rows[0];
const bountyId = bounty.id;

if (!['open', 'funded'].includes(bounty.status)) {
return NextResponse.json({ error: `Bounty is already ${bounty.status}` }, { status: 409 });
// Only a funded bounty may be claimed. A bounty stays 'open' until the CoinPay
// funding webhook flips it to 'funded'; accepting 'open' here let an unfunded
// bounty (abandoned/failed creator payment) be claimed and still trigger a real
// payout from the merchant wallet below.
if (bounty.status !== 'funded') {
return NextResponse.json({ error: `Bounty is not funded yet (status: ${bounty.status})` }, { status: 409 });
}
if (bounty.creator_did === did) {
return NextResponse.json({ error: 'Cannot claim your own bounty' }, { status: 400 });
Expand All @@ -35,7 +39,7 @@ export async function POST(req: NextRequest, { params }: { params: Promise<{ id:
UPDATE bounties
SET status = 'claimed', coupon_id = ${coupon_id}, claimer_did = ${did},
updated_at = ${new Date().toISOString()}
WHERE id = ${bountyId} AND status IN ('open', 'funded')
WHERE id = ${bountyId} AND status = 'funded'
`;

// Verify the claim succeeded (handles concurrent claim race)
Expand Down