Rename eclipse_magic.lua to eclipse.lua - #2
Open
praetp wants to merge 1 commit into
Open
Conversation
Magic Lantern's Lua loader only picks up scripts whose base filename fits in the 8.3 convention (up to 8 characters before the extension). With the previous 13-character name, the script silently fails to appear in the Scripts menu on affected ML builds/bodies, while other shorter-named .lua scripts on the same card show up normally. Renaming to eclipse.lua makes the script discoverable out of the box, with no user-side rename step required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Magic Lantern's Lua loader only picks up scripts whose base filename fits in the 8.3 convention (up to 8 characters before the extension). With the previous 13-character name, the script silently fails to appear in the Scripts menu on affected ML builds/bodies, while other shorter-named .lua scripts on the same card show up normally.
Renaming to eclipse.lua makes the script discoverable out of the box, with no user-side rename step required.