fix(release): require passing test gate - #34
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the reusable release workflow enforce tests as a hard gate for producing the release (and any release-preparation PR), while preserving skip_tests as an explicit override for exceptional cases.
Changes:
- Removes
continue-on-error: truefrom thetestjob so test failures surface as real workflow failures. - Updates the
releasejob condition to require eitherskip_tests == trueorneeds.test.result == 'success'.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release tests were marked advisory, allowing the workflow to open a release-preparation PR after a failing Linux Rust build. This makes tests a required release gate, while retaining the explicit skip_tests override for intentional exceptions.\n\nValidated with actionlint; its only findings are five pre-existing constant-if warnings outside this change.