Permit to Inject GlpiAsset#620
Conversation
|
Hello @tsmr, Thank you! |
…injection into InjectGlpiAsset
There was a problem hiding this comment.
No test (unit or functional) validates that a GlpiAsset custom asset definition can actually be injected end-to-end. Given the size of the change (492 lines, dynamic eval()-based class generation, a new capacity with register/unregister lifecycle), and that the plugin already has unit tests for comparable injection classes (tests/unit/GroupInjectionTest.php, tests/unit/CommonInjectionLibDataAlreadyInDbTest.php), a test is both feasible and needed here. Can you add a unit or functional test that enables IsInjectableCapacity on an asset definition, injects a row through the generated AssetInjection subclass, and asserts the resulting asset item?
Checklist before requesting a review
Please delete options that are not relevant.
Description
Permit to Inject GlpiAsset (and add Injectable Capacity)
Warning this development d'ont add type & model injection of GlpiAsset