Stabilize discovered SSH host row handler#3485
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
onConnectclosure passed to each memoizedDesktopSshHostRowwith a stableuseCallbackhandler.Why
React Doctor flagged
ConnectionsSettings.tsxforno-inline-prop-on-memo-componentat the discovered SSH host rows. The inline function changed identity on every parent render, defeatingmemo()for every suggested host row. A stable callback preserves behavior while allowing those rows to avoid unnecessary renders.UI Changes
Interaction behavior is unchanged. React Scan recordings captured the render behavior:
/opt/cursor/artifacts/react_scan_before_ssh_host_rows.mp4/opt/cursor/artifacts/react_scan_after_ssh_host_rows.mp4Checklist
Note
Memoize
onConnecthandler for discovered SSH host rows inConnectionsSettingsReplaces the inline arrow function passed as
onConnecttoDesktopSshHostRowwith auseCallback-memoized handler (handleConnectDiscoveredSshHost). This stabilizes the prop reference across renders whenhandleConnectSshHostis unchanged, avoiding unnecessary re-renders ofDesktopSshHostRow.Macroscope summarized 1738ae8.