Skip to content

fix(cursor): default binary path to cursor-agent PR Description#3481

Open
Aditya190803 wants to merge 2 commits into
pingdotgg:mainfrom
Aditya190803:fix/cursor-default-binary-path
Open

fix(cursor): default binary path to cursor-agent PR Description#3481
Aditya190803 wants to merge 2 commits into
pingdotgg:mainfrom
Aditya190803:fix/cursor-default-binary-path

Conversation

@Aditya190803

@Aditya190803 Aditya190803 commented Jun 21, 2026

Copy link
Copy Markdown

Fixes #3479

When Grok CLI is installed alongside Cursor, the shared agent command name resolves to Grok and breaks Cursor ACP discovery. Default Cursor to cursor-agent, map legacy agent configs on decode, and align update probes and spawn fallbacks with the new binary name.

What Changed

  • Changed the default Cursor binaryPath from agent to cursor-agent
  • Added decode-time migration so existing configs with binaryPath: "agent" resolve to cursor-agent (explicit full paths are unchanged)
  • Updated Cursor ACP spawn fallbacks, provider update probes, and related tests to use cursor-agent

Why

T3 was invoking agent acp for Cursor provider discovery. On machines where both Grok CLI and Cursor are installed, agent often resolves to Grok first, causing Cursor ACP model discovery to fail with AcpTransportError even though cursor-agent works correctly.

cursor-agent is the correct Cursor CLI binary name and avoids this collision. Mapping legacy "agent" values preserves existing user configs without requiring a manual settings change.

UI Changes

N/A — server-side provider discovery and settings default only. The settings placeholder now shows cursor-agent instead of agent.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Targeted provider binary resolution and settings decode migration; no auth or data-path changes, with explicit custom binary paths preserved.

Overview
Fixes Cursor invoking the wrong CLI when Grok’s shared agent name wins on PATH by standardizing on cursor-agent for spawn, ACP discovery, and provider self-updates.

Settings: CursorSettings.binaryPath now defaults to cursor-agent, with normalizeCursorBinaryPath rewriting legacy bare "agent" on decode; explicit paths (e.g. /usr/local/bin/agent) are unchanged. The settings placeholder reflects the new default.

Server alignment: buildCursorAcpSpawnInput, CursorDriver maintenance (cursor-agent update), the model-mismatch probe script, and tests/fixtures are updated to expect cursor-agent instead of agent.

Reviewed by Cursor Bugbot for commit e9d51bf. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Default Cursor binary path to cursor-agent instead of agent

  • Updates all defaults and fallbacks for the Cursor binary path from "agent" to "cursor-agent" across spawn inputs, driver config, and the probe script.
  • Adds normalizeCursorBinaryPath in settings.ts and a new makeCursorBinaryPathSetting schema factory that trims, defaults to "cursor-agent", and maps the legacy value "agent" to "cursor-agent" on decode.
  • Behavioral Change: existing configurations storing "agent" as binaryPath will be silently normalized to "cursor-agent" at decode time.

Macroscope summarized e9d51bf.

When Grok CLI is installed alongside Cursor, the shared `agent` command
name resolves to Grok and breaks Cursor ACP discovery. Default Cursor to
`cursor-agent`, map legacy `agent` configs on decode, and align update
probes and spawn fallbacks with the new binary name.
@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 01271070-eccf-46b5-bf31-f5461d7cecca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jun 21, 2026
@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Jun 21, 2026
@macroscopeapp

macroscopeapp Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR changes the default executable binary path from 'agent' to 'cursor-agent' and adds migration logic that transforms existing configurations. Changes to which binary gets spawned affect runtime behavior and should be verified by someone familiar with the deployment environment. The author is also a new contributor to this repository.

You can customize Macroscope's approvability policy. Learn more.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a4608306a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

provider: DRIVER_KIND,
packageName: null,
updateExecutable: "agent",
updateExecutable: "cursor-agent",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align Cursor recovery command with cursor-agent

When Cursor reports an old CLI version or non-lab channel, getCursorParameterizedModelPickerUnsupportedMessage still tells users to run agent set-channel lab && agent update (apps/server/src/provider/Layers/CursorProvider.ts:784). In the Grok-alongside-Cursor setup this change is fixing, that command still resolves to Grok, so affected users remain stuck in the unsupported state even though the maintenance command now uses cursor-agent; please update the hard-coded recovery command to match this executable.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default Cursor binary to cursor-agent to avoid Grok agent collision

1 participant