[codex] Refactor project and workspace Effect services

[juliusmarminge]

Summary

• hoisted the project, workspace, and server-environment Effect services into canonical domain-root modules
• colocated schemas, inline Context.Service contracts, real make implementations, and canonical layer exports, using Service["Service"] instead of standalone shape types
• updated in-scope consumers to service-module namespace imports while keeping contracts, utility packages, config-free helpers, and implementation helpers as named imports
• preserved module, service-contract, method, and implementation documentation while moving implementations
• removed the legacy Services/ and Layers/ compatibility modules and rewired every remaining caller to canonical domain-root modules

Scope

Orchestration, MCP, and integration-harness behavior remains unchanged; their imports and layer references are mechanically rewired to the canonical domain-root modules so no legacy compatibility paths remain.

Validation

• changed backend suites: 21 files, 369 tests passed
• vp check: 0 errors; 20 pre-existing warnings
• vp run typecheck: 15/15 tasks passed
• canonical audit: 8 root service modules with inline contracts and exported make/layer
• import audit: no whole-package contracts namespace imports and no namespace imports for pure helper modules
• test declarations: 2,228 before and after
• git diff --check
• no unresolved review threads

---

Note

Medium Risk
Wide refactor across workspace file I/O, project setup scripts, and server startup error shapes; behavior is mostly preserved but client-visible error messages and failure payloads changed in several paths.

Overview
This PR consolidates several Effect services (ServerEnvironment, RepositoryIdentityResolver, ProjectFaviconResolver, ProjectSetupScriptRunner, WorkspacePaths, WorkspaceEntries, WorkspaceFileSystem) into canonical domain-root modules that colocate the Context.Service tag, make, and exported layer. It deletes the old project/workspace/environment Services/ and Layers/ compatibility files and rewires orchestration, CLI, MCP, relay, assets, and integration tests to namespace imports (e.g. WorkspacePaths.layer, RepositoryIdentityResolver.RepositoryIdentityResolver).

ProjectSetupScriptRunner is reimplemented at the project root with Schema tagged errors (ProjectSetupScriptOperationError, ProjectSetupScriptProjectNotFoundError) instead of a single message-only error; Git/bootstrap and server tests now expect operation-specific failure text.

Workspace browse/search/list and file read/write gain structured error types (WorkspaceEntriesCurrentProjectRequiredError, WorkspaceEntriesReadDirectoryError, WorkspaceFileSystemError with cause, etc.). WebSocket RPC handlers map many workspace failures to generic client messages (e.g. "Failed to search workspace entries.") while retaining cause on the error object.

ServerRuntimeStartupError now carries mode / host / port and a required cause instead of a command-readiness stage field; startup tests were updated accordingly.

Minor mechanical cleanups include direct Node builtin imports (createServer, createPublicKey, readdir) where files were touched.

^{Reviewed by Cursor Bugbot for commit 8fd3f54. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Refactor project and workspace services to use Context.Service tags and consolidated module paths

• Replaces scattered Services/* and Layers/* module paths with consolidated per-feature modules (e.g. WorkspacePaths, ProjectFaviconResolver, RepositoryIdentityResolver, ServerEnvironment, ProjectSetupScriptRunner) each exporting a layer and a Context.Service tag.
• Rewrites WorkspacePaths, WorkspaceEntries, WorkspaceFileSystem, and ProjectSetupScriptRunner with typed tagged error classes (e.g. WorkspaceRootNotExistsError, WorkspaceEntriesCurrentProjectRequiredError, ProjectSetupScriptOperationError) replacing generic error strings.
• Adds ProjectSetupScriptRunner as a proper Effect service with runForThread, typed success/failure results, and tests covering no-script and terminal-start paths.
• Adds WorkspaceFileSystem as a new service with readFile enforcing root containment, file-type validation, size limits, and binary detection.
• Updates all consumers across orchestration, CLI, relay, MCP, cloud, and integration layers to use the new module paths and .layer exports.
• Behavioral Change: RPC error messages for workspace search, list, read-file, and browse are now generic strings (e.g. "Failed to search workspace entries.") rather than including internal cause.detail text.

^{Macroscope summarized 8fd3f54.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b5d4cc3c-f149-4977-95b8-597e2f11a797

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/effect-service-server-workspace-project

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🚀 Expo continuous deployment is ready!

• Project → t3-code
• Platforms → android, ios
• Scheme → t3code-preview

	🤖 Android	🍎 iOS
Fingerprint	fe5a51f2e189da69dfc4c2cd458e6cfb5fdff2ea	ae3bd597809dfd7771d0898f735d172973d4c1c8
Build Details	Build Permalink Details Distribution: INTERNAL Build profile: preview:dev Runtime version: fe5a51f2e189da69dfc4c2cd458e6cfb5fdff2ea App version: 0.1.0 Git commit: 4110b7ef4c76a5d3c990eb7ab6dfce6c771c624c	Build Permalink Details Distribution: INTERNAL Build profile: preview:dev Runtime version: ae3bd597809dfd7771d0898f735d172973d4c1c8 App version: 0.1.0 Git commit: 4110b7ef4c76a5d3c990eb7ab6dfce6c771c624c
Update Details	Update Permalink Details Branch: pr-3190 Runtime version: fe5a51f2e189da69dfc4c2cd458e6cfb5fdff2ea Git commit: 4110b7ef4c76a5d3c990eb7ab6dfce6c771c624c	Update Permalink Details Branch: pr-3190 Runtime version: ae3bd597809dfd7771d0898f735d172973d4c1c8 Git commit: 4110b7ef4c76a5d3c990eb7ab6dfce6c771c624c
Update QR

[macroscopeapp]

Approvability

Verdict: Approved

This PR consolidates Effect service definitions from separate Layers/Services directories into unified modules. The changes are mechanical reorganization (file moves, import updates, export name standardization) with no runtime behavior changes beyond minor error message improvements.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 3278f2b

Dismissing prior approval to re-evaluate 711d999

Dismissing prior approval to re-evaluate 6cca072

Dismissing prior approval to re-evaluate 91d61c1

Dismissing prior approval to re-evaluate 8fd3f54