tpcc: close prepared statements before RefreshConn#209
Open
together-wang wants to merge 1 commit into
Open
Conversation
together-wang
marked this pull request as ready for review
July 13, 2026 08:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #208.
Why
When a TPCC connection is refreshed after a failed ping or at the configured refresh interval, the old prepared statements were left open while the new connection prepared another full statement set. Repeating this cycle can retain server-side prepared statements and their associated parser/plan-cache memory.
Closing the old statements before
RefreshConnreleases the old connection's statement resources before the new set is prepared.Validation
GOEXPERIMENT=jsonv2 go test ./tpcc ./pkg/workload -count=1GOEXPERIMENT=jsonv2 go test ./... -count=1GOEXPERIMENT=jsonv2 go vet ./...