fix(appstore): catalogue list uses DisplayName headline, not full Description (PILOT-405)#362
Open
matthew-pilot wants to merge 1 commit into
Open
fix(appstore): catalogue list uses DisplayName headline, not full Description (PILOT-405)#362matthew-pilot wants to merge 1 commit into
matthew-pilot wants to merge 1 commit into
Conversation
…cription (PILOT-405) The catalogue list previously printed the full Description field for every entry, which is designed to be multi-sentence prose (especially in v2 catalogue entries where display_name is the short headline). This contradicts the intended UX: list = quick glance, view = full detail. Change: the text-mode listing now prints DisplayName when present, falling back to Description for v1 catalogue entries that lack the newer field. The --json output is unchanged — it still emits the entire catalogueEntry struct so downstream consumers are unaffected. Added explicit tests for: - DisplayName is used as headline when present (full Description NOT leaked) - Fallback to Description when DisplayName is absent (v1 back-compat) Closes PILOT-405
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
pilotctl appstore cataloguelist now prints the short headline (DisplayName) instead of the full Description for each app entry.Why
The catalogue list is a quick-glance surface — the full Description is meant for
pilotctl appstore view <id>. When a v2 catalogue entry has bothdisplay_name(short) anddescription(long prose), the list was incorrectly printing the long description, contradicting the intended UX.Changes
DisplayNamewhen present, fall back toDescriptionfor v1 back-compat--jsonoutput: unchanged (emits fullcatalogueEntrystruct)Verification
go build ./cmd/pilotctl/✓go vet ./cmd/pilotctl/✓go test -run 'TestCmdAppStoreCatalogue' ./cmd/pilotctl/✓ (all 6 tests pass)2 files changed, 54 insertions(+), 1 deletion(-)
Closes PILOT-405