fix: ensure sitemap.xml emits a single XML declaration - #375
Open
fatima-Sami55 wants to merge 1 commit into
Open
fix: ensure sitemap.xml emits a single XML declaration#375fatima-Sami55 wants to merge 1 commit into
fatima-Sami55 wants to merge 1 commit into
Conversation
Google Search Console rejects duplicated <?xml?> prologs that browsers still accept. Strip any declarations, emit exactly one, validate <urlset>, and fail the build if the invariant breaks.
|
@fatima-Sami55 is attempting to deploy a commit to the PhysicsHub's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hi maintainers — the Vercel preview for this PR is waiting on authorization (fork contributor). Lint & Format Check has already passed. Could someone with access please authorize the deployment here? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sitemap.xmlstill ships with a duplicated<?xml?>prolog, which Google Search Console rejects as invalid XML (browsers hide the problem).scripts/sitemap-generator.jsto strip any XML declarations, emit exactly one, require a leading<urlset>, and fail the build if that invariant breaks.public/sitemap.xmlwith a single declaration and refreshedlastmoddates.Why this matters
Production currently returns:
This PR makes generation idempotent so a future prepend/format change cannot reintroduce the duplicate.
Test plan
<urlset><url>entries and closes</urlset>sitemap.xmlin Google Search Console and confirm it is no longer rejectedFixes #107